# Pull Requests
# Submitting a pull request
Ensure your PR meet our guidelines, where applicable:
- I implemented a fully responsive (Mobile/Tablets/Desktop/Desktop wider) component
- The implemented design closely follows the source in all breakpoints
- I included the fully functional and documented-where-needed ACF group for this component
- The included ACF field groups follow the Page Builder (ACF) Guidelines
- The HTML and SCSS follows the Component & Module Guidelines
- All the typography styles are imported from
typography.scss. See Typography - I didn't introduce new typography styles that were not already in
typography.scss - All the module spacing logic is imported from
modules.scss - I have tested this in all supported browsers
- The frontend component in all it's variants is passing AXE and WAVE automated checks without errors
- I found no accessibility issues doing a manual assessment using NVDA on Firefox (if on Windows) or VoiceOver on Safari (if on Mac).
- My branch follows the naming scheme
developer name initials/Jira Ticket uppercase/optional short descriptione.g.gr/OC-01/initial-setup
# After merging
- Delete your merged branch
- If applicable, add one or more instance of the module/feature to the Module Catalog page on the staging site
- Transition the Jira issue to Done